fix: alias model names collision with component types #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jshhhh
force-pushed
the
component-model-alias
branch
from
c05f60b
to
561b4c9
Compare
Codecov Report
@@ Coverage Diff @@
## tagged-release/forms-hotfix #733 +/- ##
===============================================================
+ Coverage 91.31% 91.37% +0.05%
===============================================================
Files 102 102
Lines 3996 4033 +37
Branches 1115 1130 +15
===============================================================
+ Hits 3649 3685 +36
- Misses 325 326 +1
Partials 22 22
Continue to review full report at Codecov.
|
* chore: set timezone to UTC before starting cypress tests * fix: cli test fix Co-authored-by: Brandon Lyons <lyonsbp@amazon.com> Co-authored-by: Scott Young <scoyou@amazon.com>
Jshhhh
force-pushed
the
component-model-alias
branch
from
561b4c9
to
ac84088
Compare
Jshhhh
force-pushed
the
component-model-alias
branch
from
ac84088
to
f86a8a0
Compare
awinberg-aws
approved these changes
Nov 1, 2022
scottyoung
approved these changes
Nov 2, 2022
Jshhhh
added a commit
that referenced
this pull request
Nov 3, 2022
* chore: set timezone to UTC before starting cypress tests (#730) * chore: set timezone to UTC before starting cypress tests * fix: cli test fix Co-authored-by: Brandon Lyons <lyonsbp@amazon.com> Co-authored-by: Scott Young <scoyou@amazon.com> * fix: alias model names collision with component types Co-authored-by: Brandon Lyons <lyonsbp@amazon.com> Co-authored-by: Scott Young <scoyou@amazon.com> Co-authored-by: Justin Shih <jushih@amazon.com>
Jshhhh
added a commit
that referenced
this pull request
Nov 3, 2022
* chore: set timezone to UTC before starting cypress tests (#730) * chore: set timezone to UTC before starting cypress tests * fix: cli test fix Co-authored-by: Brandon Lyons <lyonsbp@amazon.com> Co-authored-by: Scott Young <scoyou@amazon.com> * fix: alias model names collision with component types Co-authored-by: Brandon Lyons <lyonsbp@amazon.com> Co-authored-by: Scott Young <scoyou@amazon.com> Co-authored-by: Justin Shih <jushih@amazon.com>
Merged
hein-j
pushed a commit
that referenced
this pull request
Nov 3, 2022
* chore: set timezone to UTC before starting cypress tests (#730) * chore: set timezone to UTC before starting cypress tests * fix: cli test fix Co-authored-by: Brandon Lyons <lyonsbp@amazon.com> Co-authored-by: Scott Young <scoyou@amazon.com> * fix: alias model names collision with component types Co-authored-by: Brandon Lyons <lyonsbp@amazon.com> Co-authored-by: Scott Young <scoyou@amazon.com> Co-authored-by: Justin Shih <jushih@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.