fix: update imports and props for aliased components #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #868 +/- ##
=======================================
Coverage 92.82% 92.83%
=======================================
Files 115 115
Lines 4807 4813 +6
Branches 1377 1379 +2
=======================================
+ Hits 4462 4468 +6
Misses 326 326
Partials 19 19
Continue to review full report at Codecov.
|
hein-j
previously approved these changes
Jan 3, 2023
Jshhhh
previously approved these changes
Jan 3, 2023
Jshhhh
reviewed
Jan 3, 2023
packages/codegen-ui-react/lib/__tests__/__snapshots__/studio-ui-codegen-react.test.ts.snap
Show resolved
Hide resolved
Jshhhh
approved these changes
Jan 4, 2023
hein-j
approved these changes
Jan 4, 2023
scottyoung
approved these changes
Jan 4, 2023
scottyoung
pushed a commit
that referenced
this pull request
Jan 9, 2023
* fix: update imports and props for aliased components * test: update tests for type declarations and same name validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
import { Grid as GridCustom } from "./Grid"import { GridProps } from "./Grid"instead ofimport { GridCustomProps } from "./GridCustom"By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.