Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for null value during form validation #902

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Jan 25, 2023

Issue #, if available:

Description of changes:

  • Null values in forms caused non required fields to be validated
  • Add check for null value during validation function

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #902 (8387195) into main (166f92b) will decrease coverage by 0.17%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   93.06%   92.89%   -0.17%     
==========================================
  Files         117      118       +1     
  Lines        5047     5068      +21     
  Branches     1485     1489       +4     
==========================================
+ Hits         4697     4708      +11     
- Misses        329      339      +10     
  Partials       21       21              
Impacted Files Coverage Δ
...gen-ui-react/lib/utils/forms/validation-helpers.ts 56.25% <56.25%> (ø)
...ges/codegen-ui-react/lib/utils/forms/validation.ts 95.00% <62.50%> (-2.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 166f92b...8387195. Read the comment docs.

@Jshhhh Jshhhh force-pushed the non-required-form-validation branch from 8387195 to befd864 Compare January 25, 2023 01:46
@Jshhhh Jshhhh marked this pull request as ready for review January 25, 2023 02:05
@Jshhhh Jshhhh requested a review from a team as a code owner January 25, 2023 02:05
@Jshhhh Jshhhh merged commit 30891e7 into main Jan 25, 2023
@Jshhhh Jshhhh deleted the non-required-form-validation branch January 25, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants