Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change timestamp check in date validation function #911

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Feb 8, 2023

Issue #, if available:

Description of changes:

  • fix before/after validation for parsing dates without alpha characters ex: 2022-01-01 and 01/01/2022

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh marked this pull request as ready for review February 8, 2023 00:11
@Jshhhh Jshhhh requested a review from a team as a code owner February 8, 2023 00:11
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Merging #911 (8f4ca91) into main (1bfcb65) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
- Coverage   93.01%   92.99%   -0.02%     
==========================================
  Files         118      118              
  Lines        5093     5094       +1     
  Branches     1501     1500       -1     
==========================================
  Hits         4737     4737              
- Misses        335      336       +1     
  Partials       21       21              
Impacted Files Coverage Δ
...gen-ui-react/lib/utils/forms/validation-helpers.ts 55.55% <50.00%> (-0.70%) ⬇️
...ges/codegen-ui-react/lib/utils/forms/validation.ts 97.84% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bfcb65...8f4ca91. Read the comment docs.

hein-j
hein-j previously approved these changes Feb 8, 2023
scottyoung
scottyoung previously approved these changes Feb 8, 2023
@Jshhhh Jshhhh dismissed stale reviews from scottyoung and hein-j via 61ce151 February 8, 2023 21:52
@Jshhhh Jshhhh force-pushed the date-validation branch 4 times, most recently from bb95804 to a2db409 Compare February 8, 2023 23:27
@Jshhhh Jshhhh merged commit cf96a1c into main Feb 9, 2023
@Jshhhh Jshhhh deleted the date-validation branch February 9, 2023 18:23
Copy link
Contributor

@cwoolum cwoolum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor tests cases so they all assert separate scenarios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants