-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve pill labels for scalar relationships #952
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #952 +/- ##
==========================================
- Coverage 93.01% 93.00% -0.02%
==========================================
Files 120 120
Lines 5255 5275 +20
Branches 1554 1562 +8
==========================================
+ Hits 4888 4906 +18
- Misses 346 348 +2
Partials 21 21
Continue to review full report in Codecov by Sentry.
|
Problem
Scalar relationships only display ID labels, which are not human readable. Customers should be able to identify related records in their forms so that they can bind based on fields other than IDs.
Solution
Scalar relationship labels now look like the labels for model fields:
[firstReadableField] - [ID]
Verification
Manual tests
scalar-pill-labels.mov
Automated tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.