feat: [API] Merge non-GraphQL spec error fields into GraphQLError.extensions #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
force-pushed
the
feature/graphql-error-extensions
branch
from
1648234
to
042391e
Compare
lawmicha
commented
Apr 24, 2020
...yPlugin/Sync/MutationSync/OutgoingMutationQueue/ProcessMutationErrorFromCloudOperation.swift
Outdated
Show resolved
Hide resolved
lawmicha
force-pushed
the
feature/graphql-error-extensions
branch
from
63cf3d9
to
5ac3f14
Compare
drochetti
reviewed
Apr 28, 2020
| return GraphQLError(message: graphQLError.message, | ||
| locations: graphQLError.locations, | ||
| path: graphQLError.path, | ||
| extensions: !mergedExtensions.isEmpty ? mergedExtensions : nil) |
There was a problem hiding this comment.
instead of the ! you could just invert the ternary result
Comment on lines
55
to
59
| if key == "message" || | ||
| key == "locations" || | ||
| key == "path" || | ||
| key == "extensions" || | ||
| mergedExtensions.keys.contains(key) { |
There was a problem hiding this comment.
you could have a list of keys and then append the mergedExtensions.keys into that list and just check for contains(key)
| throw APIError.unknown(""" | ||
| Unexpected failure while decoding GraphQL response containing errors: | ||
| \(String(describing: graphQLErrors)) | ||
| """, "", error) |
There was a problem hiding this comment.
should that second argument contain something? Does the "report to AWS" suggestion fit here?
There was a problem hiding this comment.
it looks like we already do that when exposed to the developer
case .unknown(_, let recoverySuggestion, _):
return """
\(recoverySuggestion)
\(AmplifyErrorMessages.shouldNotHappenReportBugToAWS())
"""
drochetti
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change merges the graphQL error values with keys which do not match the GraphQL spec into the extensions JSON.
Android PR for reference aws-amplify/amplify-android#392
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.