Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isSignUpComplete flag set to false #760

Closed
haverchuck opened this issue Sep 8, 2020 · 5 comments
Closed

isSignUpComplete flag set to false #760

haverchuck opened this issue Sep 8, 2020 · 5 comments
Assignees
Labels
auth Issues related to the Auth category bug Something isn't working documentation Documentation improvements follow up Requires follow up from maintainers
Milestone

Comments

@haverchuck
Copy link
Contributor

Describe the bug
Upon creating a userpool record using the .signUp method, the result contains an 'isSignUpComplete' flag which is set to false. As indicated by the discussion in this amplify-android issue, the expectation is that this flag should be set to true (even if confirmation is still needed).

To Reproduce
Steps to reproduce the behavior:

  1. Call 'signUp' on a userpool which requires confirmation.
  2. Receive a response indicating that the next step is CONFIRM_SIGN_UP_STEP
  3. Note that 'isSignUpComplete' is 'false.

Expected behavior
As indicated here, isSignUpComplete should be true.

Environment(please complete the following information):

  • Amplify Framework Version: 1.1.2
  • Dependency Manager: Cocoapods
  • Swift Version : 11.0

Device Information (please complete the following information):

  • Device: iPhone 11 Simulator
  • iOS Version: 11 (13.7)
@royjit royjit added auth Issues related to the Auth category pending-triage Issue is pending triage labels Sep 8, 2020
@palpatim
Copy link
Member

palpatim commented Sep 8, 2020

Please see discussion on aws-amplify/amplify-android#686 -- my recollection of that decision differs from @TrekSoft's.

@henryouang
Copy link

Create a lambda function to automatically flag it to true when a user signs up. You can set the trigger in amplify auth console

@TrekSoft
Copy link
Contributor

TrekSoft commented Oct 5, 2020

@palpatim I responded to your comment over on the Android ticket btw

@palpatim
Copy link
Member

palpatim commented Jul 9, 2021

The existing behaviors across platforms are incompatible, and cannot be resolved without breaking one platform or another.

Next steps:

  • Document the behavior of the flag in each platform, with a warning or alert that the behavior differs across platforms
  • When the time comes to look at Auth 2.0, consider what the desired behavior is and write tests across platforms to assert that desired behavior

I am flagging this as a "documentation" bug now. Once we resolve the documentation part of this, we can re-characterize it as a feature request.

@palpatim palpatim added documentation Documentation improvements bug Something isn't working labels Jul 9, 2021
@royjit
Copy link
Member

royjit commented Jun 3, 2022

Closing this issue since we are changing this in Android - aws-amplify/amplify-android#686

@royjit royjit closed this as completed Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Issues related to the Auth category bug Something isn't working documentation Documentation improvements follow up Requires follow up from maintainers
Projects
None yet
Development

No branches or pull requests

7 participants