Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Authenticator uneffective Hide feature #1191

Closed
ksavidetove opened this issue Jul 10, 2018 · 12 comments
Closed

Angular Authenticator uneffective Hide feature #1191

ksavidetove opened this issue Jul 10, 2018 · 12 comments
Assignees
Labels
Angular Related to Angular 2+ bug Something isn't working

Comments

@ksavidetove
Copy link
Contributor

Do you want to request a feature or report a bug?
Bug Report

What is the current behavior?
The [hide] property of the Angular built-in Authenticator applies on the elements, but not on the links, that send the user to nowhere.

singin page

This is the Sign In page with 'SignUp' and 'ForgotPassword' hidden. The links are still there but they redirect to nowhere.

Expected behavior?
Hide the links too.

@powerful23 powerful23 added Angular Related to Angular 2+ investigating This issue is being investigated labels Jul 10, 2018
@powerful23
Copy link
Contributor

@ksavidetove Thanks. We will investigate this issue and also review you pr.

@haverchuck
Copy link
Contributor

haverchuck commented Jul 10, 2018

@ksavidetove - When you were seeing this behavior were you using the "authenticator" component (which acts as a parent for the other auth components), or were you using the "sign-in" component in isolation?

@ksavidetove
Copy link
Contributor Author

I was using the authenticator element. So from this parent element, the default view is the Sign In, but with a link to Sign Up displayed even if I hid it. And when you use this link, the authenticator remembers that you wanted to hide this part and presents you nothing. And you are stuck there.

@haverchuck haverchuck self-assigned this Jul 16, 2018
@ksavidetove
Copy link
Contributor Author

Any update on this issue?

@sairathb
Copy link

Hi, I am facing a similar issue, <amplify-authenticator [hide]="['ForgotPassword', 'SignUp']"></amplify-authenticator> seem to be hiding the component, but the links in the Sign In component is still visible. When I click on them it shows a blank page. Is someone working to remove the links if the components are marked to hide? I am using the version 2.1.6-unstable.1 where the hide problem was fixed. Found details from the other bug

@sairathb
Copy link

I think if we pass the hide attribute to the sign-in component, then it can be accessed in the same way as in the authenticator. I can create a pull request for this, since I have the code change, but I don't have permissions
image

@AGoodnight
Copy link

AGoodnight commented Jan 21, 2019

I find that even if I use:
<amplify-authenticator [hide]="['SignUp','ConfirmSignUp']"></amplify-authenticator>

It will still take me to SignUp. So for me the hide functionality is not working at all.

@jordanranz jordanranz added bug Something isn't working and removed investigating This issue is being investigated labels Mar 1, 2019
@jarrettj
Copy link

Yup, same issue here. Good to know it is a bug and not me going cuckoo. :)

@vjindalaurea
Copy link

Hi , any update on it ?

@powerful23
Copy link
Contributor

Closing as this should have been fixed by #3173

@ddurham2
Copy link

Maybe a n00b question, but when I use <amplify-authenticator [hide]="['SignUp','ConfirmSignUp']">
I get a compile time error:

Error: src/app/app.component.html:1:25 - error NG8002: Can't bind to 'hide' since it isn't a known property of 'amplify-authenticator'.
1. If 'amplify-authenticator' is an Angular component and it has 'hide' input, then verify that it is part of this module.
2. If 'amplify-authenticator' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the '@NgModule.schemas' of this component to suppress this message.
3. To allow any property add 'NO_ERRORS_SCHEMA' to the '@NgModule.schemas' of this component.

1 <amplify-authenticator  [hide]="['SignUp','ConfirmSignUp']">
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

If I need to import AuthenticatorComponent, it's not readily apparent the path I should import it from.

Thanks

@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Angular Related to Angular 2+ bug Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants