Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remembered device's friendly name #13165

Closed
2 tasks
Milad-Akarie opened this issue Mar 24, 2024 · 3 comments
Closed
2 tasks

Remembered device's friendly name #13165

Milad-Akarie opened this issue Mar 24, 2024 · 3 comments
Assignees
Labels
Auth Related to Auth components/category bug Something isn't working duplicate If marked with duplicate, issue will be closed & original will be added for traceability

Comments

@Milad-Akarie
Copy link

Milad-Akarie commented Mar 24, 2024

Is this related to a new or existing framework?

Angular

Is this related to a new or existing API?

Authentication

Is this related to another service?

No response

Describe the feature you'd like to request

When listing the remembered devices there's no way to display a friendly name for users to recognize the them.
I tried passing deviceFriendlyName with both verifyTOTPSetup and confirmSignIn but I still can't get the name I pass inside AWSAuthDevice

Describe the solution you'd like

I'd like to have access to the deviceFriendlyName I assign inside AWSAuthDevice

Describe alternatives you've considered

I can not think of any

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@Milad-Akarie Milad-Akarie added the pending-triage Issue is pending triage label Mar 24, 2024
@nadetastic nadetastic added the Auth Related to Auth components/category label Mar 25, 2024
@cwomack cwomack self-assigned this Mar 25, 2024
@cwomack
Copy link
Contributor

cwomack commented Mar 26, 2024

Hello, @Milad-Akarie and sorry to hear you're running into this issue. This sounds like it is related to the known bug of #12854, but wanted to double check with you on the API's that you're trying to use here. Is the intent here to use the v6 Auth API's of rememberDevice() (docs link) and fetchDevices() (docs link) to get a device's friendly name?

If so, can you review the linked/related issue and let me know if it captures the scope of what you're reporting here? We can track any additional context or requests within that issue if so as we work on a fix. Thanks!

@cwomack cwomack added investigating This issue is being investigated pending-response Issue is pending response from the issue requestor labels Mar 26, 2024
@Milad-Akarie
Copy link
Author

Hey @cwomack Yup, closing this as a duplicate of #12854

@github-actions github-actions bot removed the pending-response Issue is pending response from the issue requestor label Mar 26, 2024
@cwomack
Copy link
Contributor

cwomack commented Mar 26, 2024

Appreciate the quick reply on this, @Milad-Akarie! Feel free to leave any additional context, upvotes, etc. on that issue.

@cwomack cwomack added bug Something isn't working duplicate If marked with duplicate, issue will be closed & original will be added for traceability and removed investigating This issue is being investigated pending-triage Issue is pending triage labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auth Related to Auth components/category bug Something isn't working duplicate If marked with duplicate, issue will be closed & original will be added for traceability
Projects
None yet
Development

No branches or pull requests

3 participants