Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): export correct module for RN #4786

Merged
merged 3 commits into from
Feb 3, 2020

Conversation

iartemiev
Copy link
Contributor

Issue #, if available:
Fixes: #4711

Description of changes:
Revert change from e61d906 to import RN-specific cache module

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #4786 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4786      +/-   ##
==========================================
+ Coverage   76.27%   76.28%   +<.01%     
==========================================
  Files         174      174              
  Lines        9641     9644       +3     
  Branches     1974     1977       +3     
==========================================
+ Hits         7354     7357       +3     
  Misses       2142     2142              
  Partials      145      145
Impacted Files Coverage Δ
packages/core/src/JS.ts 88.54% <100%> (ø) ⬆️
packages/auth/src/Auth.ts 85.91% <75%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 331d237...2213670. Read the comment docs.

@sammartinez sammartinez added Analytics Related to analytics needs-review Used as a label in order to review open PRs React Native React Native related issue labels Jan 28, 2020
Copy link
Contributor

@Amplifiyer Amplifiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Can we test just exporting the cache module and verify in RN that CJS modules are being loaded and not ESM.

Also this might be related #4351

@iartemiev
Copy link
Contributor Author

@Amplifiyer
Tested importing the Cache package separately and it's working as expected in RN

Copy link
Contributor

@Amplifiyer Amplifiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@iartemiev iartemiev merged commit a15730c into aws-amplify:master Feb 3, 2020
@iartemiev iartemiev deleted the issue4711 branch February 3, 2020 22:33
Ashish-Nanda pushed a commit to Ashish-Nanda/amplify-js that referenced this pull request Feb 12, 2020
* fix(cache): export correct module for RN

* Delete stray index-rn files
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Analytics Related to analytics needs-review Used as a label in order to review open PRs React Native React Native related issue
Projects
None yet
3 participants