-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cache): export correct module for RN #4786
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4786 +/- ##
==========================================
+ Coverage 76.27% 76.28% +<.01%
==========================================
Files 174 174
Lines 9641 9644 +3
Branches 1974 1977 +3
==========================================
+ Hits 7354 7357 +3
Misses 2142 2142
Partials 145 145
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! Can we test just exporting the cache module and verify in RN that CJS modules are being loaded and not ESM.
Also this might be related #4351
@Amplifiyer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
* fix(cache): export correct module for RN * Delete stray index-rn files
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Fixes: #4711
Description of changes:
Revert change from e61d906 to import RN-specific cache module
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.