Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A suggestion regarding typings for the Amplify.configure() function #5095

Closed
ryands17 opened this issue Mar 14, 2020 · 3 comments
Closed

A suggestion regarding typings for the Amplify.configure() function #5095

ryands17 opened this issue Mar 14, 2020 · 3 comments
Labels
Auth Related to Auth components/category feature-request Request a new feature fixed-in-dev-preview Issues that are fixed in v6 dev preview TypeScript Related to TypeScript issues

Comments

@ryands17
Copy link

Hey @dabit3 , I had sent added a comment on your tweet regarding the improvements that could be made to the Amplify docs but I had mentioned a couple of enchancements that I could contribute to, if possible.

I had the following points in mind and have created an example repository for the same.

  1. The Amplify.configure() and the Auth.configure() have a config type of any. Is is possible to add types for these?

  2. I have created a getToken method in the auth.tsx file in the above repo that obtains the token from either a username/password login or a social login for validating against API's. Is this the correct way to obtain the token or is there any other inbuild method that amplify provides?

@ryands17 ryands17 added the feature-request Request a new feature label Mar 14, 2020
@amhinson amhinson added the TypeScript Related to TypeScript issues label Oct 20, 2020
@abdallahshaban557 abdallahshaban557 added the Auth Related to Auth components/category label Jun 3, 2022
@abdallahshaban557 abdallahshaban557 added this to the Cognito Pluggable milestone Jun 3, 2022
@abdallahshaban557 abdallahshaban557 changed the title A suggestion regarding typings A suggestion regarding typings for the Amplify.configure() function Mar 14, 2023
@jimblanc
Copy link
Contributor

We have published an RFC on our plan for improving TypeScript support in Amplify JS & would love to get your feedback & suggestions!

RFC: Amplify JS TypeScript Improvements

@cwomack
Copy link
Contributor

cwomack commented Oct 3, 2023

The developer preview for v6 of Amplify has officially been released with improved support for TypeScript and much more! Please check out our announcement and updated documentation to see what has changed.

This issue should be resolved within the dev preview and upcoming General Availability for Amplify v6, but let us know with a comment if there are further issues.

@cwomack cwomack added the fixed-in-dev-preview Issues that are fixed in v6 dev preview label Oct 3, 2023
@cwomack
Copy link
Contributor

cwomack commented Nov 16, 2023

With the release of the latest major version of Amplify (aws-amplify@>6), this issue should now be resolved! Please refer to our release announcement, migration guide, and documentation for more information.

@cwomack cwomack closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auth Related to Auth components/category feature-request Request a new feature fixed-in-dev-preview Issues that are fixed in v6 dev preview TypeScript Related to TypeScript issues
Projects
None yet
Development

No branches or pull requests

5 participants