Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@aws-amplify/datastore): Make DataStore available in aws-amplify… #5202

Merged
merged 3 commits into from
Mar 26, 2020

Conversation

manueliglesias
Copy link
Contributor

… package

Issue #, if available:
N/A

Description of changes:
Make DataStore available in the Amplify object when using the aws-amplify package

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@manueliglesias manueliglesias added the DataStore Related to DataStore category label Mar 26, 2020
Copy link
Contributor

@Ashish-Nanda Ashish-Nanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @aws-amplify/datastore will not be installed when you install aws-amplify

Copy link
Contributor

@Ashish-Nanda Ashish-Nanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 🚀 🚀

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #5202 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5202   +/-   ##
=======================================
  Coverage   73.21%   73.22%           
=======================================
  Files         193      193           
  Lines       11441    11442    +1     
  Branches     2218     2302   +84     
=======================================
+ Hits         8377     8378    +1     
+ Misses       2916     2900   -16     
- Partials      148      164   +16     
Impacted Files Coverage Δ
packages/core/src/Amplify.ts 100.00% <100.00%> (ø)
packages/auth/src/OAuth/OAuth.ts 48.12% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 25.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 67.59% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 31.25% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts 34.09% <0.00%> (ø)
packages/datastore/src/sync/processors/sync.ts 18.05% <0.00%> (ø)
...ackages/datastore/src/storage/adapter/indexeddb.ts 73.26% <0.00%> (ø)
...ackages/pubsub/src/Providers/AWSAppSyncProvider.ts 66.66% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0b8e1...b61bdf4. Read the comment docs.

Copy link
Contributor

@Amplifiyer Amplifiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🚢 it

@manueliglesias manueliglesias merged commit c9c020d into aws-amplify:master Mar 26, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DataStore Related to DataStore category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants