Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@aws-amplify/ui-react): withAuthenticator(Component[, props]) #5204

Conversation

ericclemmons
Copy link
Contributor

@ericclemmons ericclemmons commented Mar 26, 2020

Issue #, if available: Delivers #171965194

Screen Shot 2020-03-26 at 12 18 28 PM

  • Add withAuthenticator(Component[, props]), where props are those of AmplifyAuthenticator (e.g. usernameAlias).
  • Add stories.
  • Add docs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ericclemmons ericclemmons changed the base branch from master to ui-components/master March 26, 2020 19:28
@ericclemmons ericclemmons self-assigned this Mar 26, 2020
@ericclemmons ericclemmons requested review from ashika01 and removed request for manueliglesias, Ashish-Nanda, elorzafe and iartemiev March 26, 2020 19:30
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #5204 into ui-components/master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           ui-components/master    #5204   +/-   ##
=====================================================
  Coverage                 75.85%   75.85%           
=====================================================
  Files                       177      177           
  Lines                      9685     9685           
  Branches                   1910     1860   -50     
=====================================================
  Hits                       7347     7347           
- Misses                     2187     2198   +11     
+ Partials                    151      140   -11     
Impacted Files Coverage Δ
packages/auth/src/OAuth/OAuth.ts 48.12% <0.00%> (ø)
packages/core/src/Credentials.ts 31.45% <0.00%> (ø)
packages/analytics/src/Analytics.ts 66.86% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 32.65% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts 35.55% <0.00%> (ø)
...ackages/pubsub/src/Providers/AWSAppSyncProvider.ts 66.66% <0.00%> (ø)
...pubsub/src/Providers/AWSAppSyncRealTimeProvider.ts 18.67% <0.00%> (ø)
...rc/Providers/AmazonAIConvertPredictionsProvider.ts 61.01% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb4f80...cc569cb. Read the comment docs.

@jordanranz
Copy link
Contributor

jordanranz commented Mar 27, 2020

This looks great, we may want to add a small README section for migrating from the old to new. What do you think?

Copy link
Contributor

@jordanranz jordanranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, nice work

Copy link
Contributor

@ashika01 ashika01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉 Ship it

@ericclemmons ericclemmons merged commit 39d84e7 into aws-amplify:ui-components/master Mar 27, 2020
@ErikCH ErikCH added UI Related to UI Components and removed Amplify UI Components labels May 19, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
UI Related to UI Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants