-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@aws-amplify/ui-react): withAuthenticator(Component[, props]) #5204
feat(@aws-amplify/ui-react): withAuthenticator(Component[, props]) #5204
Conversation
Codecov Report
@@ Coverage Diff @@
## ui-components/master #5204 +/- ##
=====================================================
Coverage 75.85% 75.85%
=====================================================
Files 177 177
Lines 9685 9685
Branches 1910 1860 -50
=====================================================
Hits 7347 7347
- Misses 2187 2198 +11
+ Partials 151 140 -11
Continue to review full report at Codecov.
|
This looks great, we may want to add a small README section for migrating from the old to new. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, nice work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🎉 Ship it
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available: Delivers #171965194
withAuthenticator(Component[, props])
, whereprops
are those ofAmplifyAuthenticator
(e.g.usernameAlias
).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.