fix(@aws-amplify/ui-react): withAuthenticator returns Component #5327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericclemmons
force-pushed
the
fix-withAuthenticator
branch
from
479eacf
to
ce643fa
Compare
jordanranz
approved these changes
Apr 8, 2020
|
Looks like there is a build failure, otherwise LGTM |
…fy-js into fix-withAuthenticator
Codecov Report
@@ Coverage Diff @@
## master #5327 +/- ##
=======================================
Coverage 72.90% 72.90%
=======================================
Files 195 195
Lines 11466 11466
Branches 2157 2157
=======================================
Hits 8359 8359
Misses 2956 2956
Partials 151 151 Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5204 made the mistake of returning a component instance (
ReactElement) instead of a Component.As I was working with SSR, the mistake becomes much more obvious:
Updated and fixed stories:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.