Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@aws-amplify/ui-react): Exclude files via .npmignore rather than files #5338

Merged

Conversation

ericclemmons
Copy link
Contributor

@aws-amplify/ui-react whitelisted files instead of ignoring:

Screen Shot 2020-04-08 at 2 16 30 PM

aws-amplify-react uses .npmignore:

Screen Shot 2020-04-08 at 2 16 34 PM


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ericclemmons ericclemmons self-assigned this Apr 8, 2020
@@ -12,7 +12,7 @@
},
"scripts": {
"test": "jest",
"build-with-test": "npm test && npm run build",
"build-with-test": "npm test && npm run build",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came from GitHub's conflict resolution UI, as it doesn't run prettier.

@ericclemmons ericclemmons merged commit 5fd7f24 into aws-amplify:master Apr 8, 2020
@ericclemmons ericclemmons deleted the rely-on-npmignore-not-files branch April 8, 2020 21:19
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants