Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign out and i18n #700

Merged
merged 8 commits into from
Apr 20, 2018
Merged

Conversation

powerful23
Copy link
Contributor

Issue #, if available:
to sign out user correctly, move i18n to common and add unit tests for i18n
Description of changes:
When only using auth, the credentials_source will be null once reloaded which causes the user.signOut() not called

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Apr 20, 2018

Codecov Report

Merging #700 into master will decrease coverage by 0.22%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
- Coverage   87.28%   87.06%   -0.23%     
==========================================
  Files          72       74       +2     
  Lines        3429     3494      +65     
  Branches      652      668      +16     
==========================================
+ Hits         2993     3042      +49     
- Misses        419      435      +16     
  Partials       17       17
Impacted Files Coverage Δ
packages/aws-amplify/src/Common/I18n/I18n.ts 94.44% <100%> (ø)
packages/aws-amplify/src/Common/I18n/index.ts 43.75% <100%> (ø)
packages/aws-amplify/src/Common/index.ts 81.81% <100%> (+0.86%) ⬆️
packages/aws-amplify/src/Auth/Auth.ts 88.66% <90%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15bbd3a...101f241. Read the comment docs.

Copy link
Contributor

@richardzcode richardzcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants