Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade client-cognito-identity and graphql #7092

Closed
yaquawa opened this issue Oct 31, 2020 · 7 comments
Closed

Upgrade client-cognito-identity and graphql #7092

yaquawa opened this issue Oct 31, 2020 · 7 comments
Labels
Build Related to build issues pending-close-response-required A response is required for this issue to remain open, it will be closed within the next 7 days.

Comments

@yaquawa
Copy link

yaquawa commented Oct 31, 2020

Describe the bug
Comes from #7013 for specific tracking purpose.

Version
4.31.1

To Reproduce
use webpack 5 as the bundler, build the package; the following errors shown up.
This can be fixed by update the upstream dependency client-cognito-identity and graphql

 WARNING  Compiled with 2 warnings                                                                                                                                                                                                                                                                            1:31:08 AM

 warning  in ./node_modules/@aws-sdk/client-cognito-identity/dist/es/runtimeConfig.browser.js

Should not import the named export 'name' (imported as 'name') from default-exporting module (only default export is available soon)

 warning  in ./node_modules/@aws-sdk/client-cognito-identity/dist/es/runtimeConfig.browser.js

Should not import the named export 'version' (imported as 'version') from default-exporting module (only default export is available soon)

Additional context
#7013

@yaquawa yaquawa added the to-be-reproduced Used in order for Amplify to reproduce said issue label Oct 31, 2020
@amhinson amhinson added the Build Related to build issues label Nov 2, 2020
@yaquawa
Copy link
Author

yaquawa commented Nov 11, 2020

Hi @amhinson
I'm waiting for this more than 3 weeks.
Could you tell me when the next version will be released ?
I really had a hard time to copy and paste the latest version of client-cognito-identity and graphql to the node_modules directory manually before each build...
just update the package.json, shouldn't be that hard I think.

Thanks.

@yaquawa
Copy link
Author

yaquawa commented Nov 12, 2020

currently hotfix this by add the following to the package.json, install the packages with yarn.

"resolutions": {
        "graphql": "^15.0.0"
    }

@martoncsikos
Copy link

fwiw I'm getting the same warnings produced by the
client-lex-runtime-service dependency in @aws-amplify/interactions and the
client-s3 dependency in @aws-amplify/storage

All the fixes are here:
aws/aws-sdk-js-v3#1505

@EdmundasD
Copy link

+1 primarily to take advantage of type definitions - I think they were introduced in 14.5.0.

@sammartinez
Copy link
Contributor

@yaquawa We are testing these scenarios listed in our GitHub Actions. Can you please validate that this is working for you on the latest version of aws-amplify. If not, can you look to open a pull request to address your use case with us? Thanks ahead of time.

@sammartinez sammartinez added pending-close-response-required A response is required for this issue to remain open, it will be closed within the next 7 days. and removed to-be-reproduced Used in order for Amplify to reproduce said issue labels Mar 23, 2021
@iartemiev
Copy link
Contributor

@yaquawa,

We are going to close this issue since we have not heard from you.

Please let us know if you still need support and provide current steps to reproduce if you haven't already. We can reopen the issue to investigate further.

Thanks

@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build Related to build issues pending-close-response-required A response is required for this issue to remain open, it will be closed within the next 7 days.
Projects
None yet
Development

No branches or pull requests

6 participants