Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

federated logins are not getting persisted in browser #71

Closed
jonsmirl opened this issue Dec 14, 2017 · 4 comments
Closed

federated logins are not getting persisted in browser #71

jonsmirl opened this issue Dec 14, 2017 · 4 comments
Labels
bug Something isn't working
Projects

Comments

@jonsmirl
Copy link

jonsmirl commented Dec 14, 2017

Using a browser and the demo React app...
login with user pool
close tab/visit site again
your session is properly restored
this works as expected

login in with google
close tab/visit site again
session is not restored
I see session data for Google stored in the browser local storage
it is just not being used to restore the session

same happens with facebook.

aws-amplify from 12/14

@jonsmirl jonsmirl changed the title federated logins are not get persisted in browser federated logins are not getting persisted in browser Dec 14, 2017
@jonsmirl
Copy link
Author

A related issue with persistent federated logins is that they should stop working if permission for the app is revoked at FB/G.

@mlabieniec mlabieniec added the investigating This issue is being investigated label Dec 15, 2017
@jonsmirl
Copy link
Author

When the app loads, the FB code gets the login status and does nothing with it.
withFacebook.jsx
fb.getLoginStatus(response => logger.debug(response));

The Google code does not appear to be getting the initial status.

@mlabieniec mlabieniec added bug Something isn't working and removed investigating This issue is being investigated labels Dec 21, 2017
@mlabieniec mlabieniec added this to Icebox in aws-amplify via automation Dec 21, 2017
@mlabieniec mlabieniec moved this from Icebox to Current Sprint in aws-amplify Dec 21, 2017
@mlabieniec
Copy link
Contributor

This should be fixed in the latest 0.1.30 that is now published, let us know if you still are running into issues here. We are working on furthering federated support.

aws-amplify automation moved this from Current Sprint to Released Dec 29, 2017
@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
aws-amplify
  
@beta
Development

No branches or pull requests

3 participants