Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-graph-signatures #743

Merged
merged 8 commits into from May 1, 2018
Merged

custom-graph-signatures #743

merged 8 commits into from May 1, 2018

Conversation

haverchuck
Copy link
Contributor

@haverchuck haverchuck commented Apr 26, 2018

Fixes #696

Issue #, if available:
[(https://github.com//issues/696)]

Description of changes:
Adds the ability to sign custom graphql requests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Apr 26, 2018

Codecov Report

Merging #743 into master will decrease coverage by 0.09%.
The diff coverage is 16.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #743     +/-   ##
========================================
- Coverage    86.6%   86.5%   -0.1%     
========================================
  Files          74      74             
  Lines        3538    3542      +4     
  Branches      674     676      +2     
========================================
  Hits         3064    3064             
- Misses        456     460      +4     
  Partials       18      18
Impacted Files Coverage Δ
packages/aws-amplify/src/API/API.ts 54.28% <16.66%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e8e9db...22c79ad. Read the comment docs.

@haverchuck
Copy link
Contributor Author

I wasn't sure if I needed to worry about a test coverage drop this small.

Copy link
Contributor

@manueliglesias manueliglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🎉

Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think we need to verify what is the expected behavior when is configured custom endpoints and appsync at the same time. Maybe a warning

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants