Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook access token not mapped correctly in federated signin #75

Closed
shb7919 opened this issue Dec 16, 2017 · 2 comments
Closed

Facebook access token not mapped correctly in federated signin #75

shb7919 opened this issue Dec 16, 2017 · 2 comments
Labels
bug Something isn't working
Projects

Comments

@shb7919
Copy link

shb7919 commented Dec 16, 2017

In aws-amplify-react package, the src/Auth/Provider/withFacebook.jsx doesn't correctly map the facebook access token when doing a federatedSignIn. It tries to map the accessToken directly from the root of the response, instead of getting it from the authResponse property of the response object.

I.e: (line 42 currently)
const { accessToken } = response;

should have been:

const { accessToken } = response.authResponse;

@mlabieniec mlabieniec added the investigating This issue is being investigated label Dec 19, 2017
@mlabieniec mlabieniec added this to Icebox in aws-amplify via automation Dec 21, 2017
@mlabieniec mlabieniec added bug Something isn't working and removed investigating This issue is being investigated labels Dec 21, 2017
@mlabieniec mlabieniec moved this from Icebox to Current Sprint in aws-amplify Dec 21, 2017
@mlabieniec
Copy link
Contributor

Fixed in #74 now published to latest release 0.1.30

aws-amplify automation moved this from Current Sprint to Released Dec 29, 2017
@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
aws-amplify
  
@beta
Development

No branches or pull requests

4 participants