Move amplify config into common module #763
Conversation
powerful23
requested review from
elorzafe,
manueliglesias,
nidsharm and
richardzcode
as code owners
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
==========================================
+ Coverage 87.46% 87.72% +0.26%
==========================================
Files 74 75 +1
Lines 3558 3593 +35
Branches 680 683 +3
==========================================
+ Hits 3112 3152 +40
+ Misses 424 419 -5
Partials 22 22
Continue to review full report at Codecov.
|
| private static _components = []; | ||
| private static _config = {}; | ||
|
|
||
| static Auth = null; |
There was a problem hiding this comment.
Are any of this being used? I think component should have a category so it can be attached.
There was a problem hiding this comment.
Those are just for backward compatibility since they will be assigned in aws-amplify/index.ts and developers may call
import Amplify from 'aws-amplify';
Amplify.Auth.signIn()
instead of
import { Auth } from 'aws-amplify';
Auth.signIn()
Will add some comments on that.
|
|
||
| static addPluggable(pluggable) { | ||
| if (pluggable && pluggable['getCategory'] && typeof pluggable['getCategory'] === 'function') { | ||
| this._components.map(comp => { |
There was a problem hiding this comment.
Where is checking the category for the component to be the same for the plugin?
There was a problem hiding this comment.
It will be checked in each category's addPluggable() method.
|
@elorzafe Cache is not registered because for that category we didn't provide such a way to configure it. You need to configure that by calling |
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.