Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed refreshing federated token logic #797

Merged
merged 1 commit into from
May 7, 2018

Conversation

mariuszluciow
Copy link

@mariuszluciow mariuszluciow commented May 6, 2018

Closes #796

Description of changes:

Changed logic of refresh to stop removing valid user if a refreshHandler is not configured for the provider.
Added a test.

Any suggestions are welcome.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #797 into master will decrease coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage   87.48%   87.46%   -0.03%     
==========================================
  Files          74       74              
  Lines        3557     3558       +1     
  Branches      679      680       +1     
==========================================
  Hits         3112     3112              
- Misses        423      424       +1     
  Partials       22       22
Impacted Files Coverage Δ
packages/aws-amplify/src/Auth/Auth.ts 88.3% <77.77%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b9cc7...859f3dc. Read the comment docs.

Copy link
Contributor

@powerful23 powerful23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for fixing that!

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants