Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component name clashing with native library cause page to hang and there's no way to delete it #694

Closed
3 tasks done
Yangobears opened this issue Oct 7, 2022 · 4 comments
Labels
bug An issue which has been identified as a bug pending-release Code has been merged but pending release studio-ui An issue that needs to be tracked by Studio Console team

Comments

@Yangobears
Copy link

Before opening, please confirm:

App Id

dlperh6l8tubt

Region

us-east-1

Environment name

Staging

Figma File Version (if applicable)

No response

Amplify CLI Version

No response

If applicable, what version of Node.js are you using?

v16.17.1

What operating system are you using?

linux

Browser type?

chrome

Describe the bug

So I accidentally name a Figma component called "Text" - not knowing Text is a primitive component in

import` { Flex, Text } from "@aws-amplify/ui-react";

My component is being created, when I click that component on the admin UI, the page would become unresponsive.
That blocks me from deleting this component.
Is there a way to delete this component from admin so "amplify pull" won't pull it cause build errors (due to name clashing again)

Expected behavior

  • component shouldn't be created/ or should be created with a rename to avoid clashing with the one from @aws-amplify/ui-react
  • I should be able to delete component in admin page/ in some ways.

Reproduction steps

  1. Create a component in Figma named "Text"
  2. Import
  3. You will get a component created, but there's no way to manage/delete that component

Project Identifier

7ce9e49a2c4bf107c0442116d84eeded

Additional information

No response

@scottyoung
Copy link

Hi @Yangobears,

Click the Edit button in the UI Library nav section, select the component(s) you wish to delete, and then click Delete selected components in the right hand pane.

Screen Shot 2022-10-10 at 9 24 51 AM

@vakalens vakalens added pending-response An issue is pending response from the issue requestor studio-ui An issue that needs to be tracked by Studio Console team labels Oct 13, 2022
@cwoolum
Copy link
Contributor

cwoolum commented Oct 24, 2022

Hi @Yangobears , we are currently working on a fix that prevent built in primitives from clashing with custom components. We'll update this ticket when the fix has rolled out.

@hein-j hein-j added the pending-release Code has been merged but pending release label Nov 1, 2022
@ykethan ykethan added bug An issue which has been identified as a bug and removed pending-response An issue is pending response from the issue requestor labels Dec 1, 2022
@ykethan
Copy link
Contributor

ykethan commented Jun 4, 2024

Closing as this has been fixed.

@ykethan ykethan closed this as completed Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue which has been identified as a bug pending-release Code has been merged but pending release studio-ui An issue that needs to be tracked by Studio Console team
Projects
None yet
Development

No branches or pull requests

6 participants