Sign in callback invoked before all sign in operations are complete

[royjit]

Describe the bug
Callback for sign is called before the actual status is set internally.

To Reproduce
We call self.performUserPoolSuccessfulSignInTasks and then calls completionHandler without waiting for the first task to complete.
https://github.com/aws-amplify/aws-sdk-ios/blob/master/AWSAuthSDK/Sources/AWSMobileClient/AWSMobileClient.swift#L480
i) Inside self.performUserPoolSuccessfulSignInTasks we call ‘mobileClientStatusChanged’
ii) After that we remove keychain values and update with new ones
iii) After that we call the two lines below
self.internalCredentialsProvider?.clearCredentials()
self.internalCredentialsProvider?.credentials()

This means that if we rely on AWSMobileClient.sharedInstance().addUserStateListener, and perform task based on the status. It will be wrong.

[royjit]

PR for the fix - #1721

[ghost]

So would this be why using getIdentityId() or invoking a Lambda based on addUserStateListener's .signedIn state fails for a certain period of time but then suddenly starts succeeding?

Any ETA on when this will be fixed?

[palpatim]

No ETA yet but we are actively working on it.

[royjit]

PR #1721 approved and pushed to develop branch.

[royjit]

Had to revert the PR since we found another callback which was invoked before signIn completes. This is caused by currentSignInHandlerCallback which is called in getTokens method during signIn.

[royjit]

This should be solved in the PR #1822.

[palpatim]

We released this in https://github.com/aws-amplify/aws-sdk-ios/releases/2.11.0

Please let us know if you have any problems with this.

[stale]

This issue has been automatically closed because of inactivity. Please open a new issue if are still encountering problems.