Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Bar for AWSMobileClient sign in #2321

Closed
FahadOsaimi opened this issue Feb 29, 2020 · 4 comments
Closed

Navigation Bar for AWSMobileClient sign in #2321

FahadOsaimi opened this issue Feb 29, 2020 · 4 comments
Labels
cognito Issues related to AWS Cognito mobile client Issues related to AWSMobileClient

Comments

@FahadOsaimi
Copy link

FahadOsaimi commented Feb 29, 2020

The Issue
Navigation Bar for AWSMobileClient sign in (showSignIn) is not appear in 13.3 and working fine in 12.2

Which AWS service(s) are affected?

AWSMobileClient.default().showSignIn(navigationController: self.recentNavController ) {(userStete, error) in if (error == nil){ DispatchQueue.main.async { print("user successfully logged in") } } }

Expected behavior
Navigation Bar should be visible not blank and Sign In title appear

Screenshots
Screen Shot 2020-02-29 at 6 43 08 PM
Screen Shot 2020-02-29 at 6 43 49 PM

Environment(please complete the following information):

  • SDK Version: [e.g. 2.6.29] 2.12.7
  • Dependency Manager: [e.g. Cocoapods, Carthage] Cocoapods
  • Swift Version : [e.g. 4.0] 5.0

Device Information (please complete the following information):

  • Device: [e.g. iPhone6, Simulator] iPhone 8 and later
  • iOS Version: [e.g. iOS 11.4] iOS 13.3
  • Specific to simulators:
@megafrost-zz megafrost-zz added mobile client Issues related to AWSMobileClient cognito Issues related to AWS Cognito labels Mar 2, 2020
@lawmicha
Copy link
Member

lawmicha commented Mar 5, 2020

Hi @FahadOs, thanks for reporting this issue. Unfortunately I was unable to reproduce this.

My pod file

platform :ios, '13.0'
AWS_SDK_VERSION = "2.12.7"
...
pod "AWSMobileClient", "~> #{AWS_SDK_VERSION}"
pod "AWSAuthUI", "~> #{AWS_SDK_VERSION}"
pod "AWSUserPoolsSignIn", "~> #{AWS_SDK_VERSION}"

Simulator Screen Shot - iPhone 8 Plus - 2020-03-05 at 09 40 26

Do you see any errors in the console related to the navigation controller? Are you able to reproduce this on a physical device? On other types of Iphone simulators (Iphone 11, X, etc) for 13.3?

@FahadOsaimi
Copy link
Author

Thank you @lawmicha so much for your reply.

I have not tested yet in a physical device but all iPhone simulators with IOS 13.3 has the same issue

I have just figure out that once the large titles attribute for navigation bar was set to true the issue will appear :

UINavigationBar.appearance().prefersLargeTitles = true

My Pod file :

# Uncomment the next line to define a global platform for your project
 platform :ios, '13.0'
 AWS_SDK_VERSION = "2.12.7"

target 'xxx' do
  # Comment the next line if you don't want to use dynamic frameworks
  use_frameworks!

  # Pods for hypinder
  pod 'AWSUserPoolsSignIn', "~> #{AWS_SDK_VERSION}"
  pod 'AWSAuthUI', "~> #{AWS_SDK_VERSION}"
  pod 'AWSMobileClient', "~> #{AWS_SDK_VERSION}"
  pod 'AWSGoogleSignIn', '~> 2.12.6'
  pod 'GoogleSignIn'
end

@royjit
Copy link
Member

royjit commented Apr 17, 2020

Hi @FahadOsaimi
Adding the following code as explained in here fixed the issue for me

UINavigationBar.appearance().prefersLargeTitles = true
let appearance = UINavigationBarAppearance()
appearance.backgroundColor = UIColor.white
UINavigationBar.appearance().scrollEdgeAppearance = appearance

@FahadOsaimi
Copy link
Author

Thank you @royjit so much , fixed the issue for me too 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cognito Issues related to AWS Cognito mobile client Issues related to AWSMobileClient
Projects
None yet
Development

No branches or pull requests

4 participants