Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::ApiGateway::DomainName- (new parameter) #3

Closed
luiseduardocolon opened this issue Jul 24, 2019 · 5 comments
Closed

AWS::ApiGateway::DomainName- (new parameter) #3

luiseduardocolon opened this issue Jul 24, 2019 · 5 comments
Labels
networking & content deliv VPC, CloudFront, Route 53, API Gateway, Direct Connect, AWS App Mesh, etc.
Milestone

Comments

@luiseduardocolon
Copy link
Contributor

luiseduardocolon commented Jul 24, 2019

Add new parameters to AWS::ApiGateway::DomainName -> Security Policy, DomainNameStatus

Scope of request -> Create Domain Name API takes additional input: security policy
3. Expected behavior -> in Create, allow setting security policy. In Update, allow changing to a different security policy.
4. Test case recommendation (optional) -> Once done, get domain name should return domain name with new attributes security policy and status
5. Links to existing API doc (optional) -> API docs at https://docs.aws.amazon.com/apigateway/api-reference/resource/domain-name/
6. Category tag (optional) -> Networking/Content Delivery
7. Any additional context (optional)

@luiseduardocolon luiseduardocolon added this to We're working on it in coverage-roadmap Jul 24, 2019
@luiseduardocolon luiseduardocolon changed the title AWS::ApiGateway::DomainName-SecurityPolicy AWS::ApiGateway::DomainName-SecurityPolicy (new parameter) Jul 25, 2019
@luiseduardocolon luiseduardocolon changed the title AWS::ApiGateway::DomainName-SecurityPolicy (new parameter) AWS::ApiGateway::DomainName- (new parameter) Jul 25, 2019
@luiseduardocolon luiseduardocolon added the networking & content deliv VPC, CloudFront, Route 53, API Gateway, Direct Connect, AWS App Mesh, etc. label Jul 30, 2019
@AmillerSC
Copy link

We are interested in this parameter being available. In the meantime, we need to update from TLS 1.0 to TLS 1.2 via Web console or AWS CLI. We are not able to define this using SAM/CF

@dan-lind
Copy link

dan-lind commented Sep 3, 2019

I would suggest making TLS 1.2 the default value for new domains, to make sure those who miss this setting is still getting the best possible security.

@benkehoe
Copy link
Contributor

benkehoe commented Sep 3, 2019

I think the response will be, "changing the default to TLS 1.2 breaks backwards compatibility". If it is, we need CloudFormation to think about better ways of versioning these resources so people can get security upgrades like this by default, but pin behavior for compatibility if needed.

@strottos
Copy link

I'd like to see this fwiw, we've just hit wanting this at my place and are now having to look into alternatives. Anything I can do to help let me know. Thanks.

@luiseduardocolon luiseduardocolon moved this from Coming Soon to Shipped in coverage-roadmap Nov 7, 2019
@kennu
Copy link

kennu commented Nov 10, 2019

Should SecurityPolicy also be in AWS::ApiGatewayV2::DomainName DomainNameConfiguration? https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apigatewayv2-domainname-domainnameconfiguration.html

@craigataws craigataws added this to the cov milestone Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
networking & content deliv VPC, CloudFront, Route 53, API Gateway, Direct Connect, AWS App Mesh, etc.
Projects
coverage-roadmap
  
Shipped
Development

No branches or pull requests

7 participants