Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functionality: support tagging #35

Open
maslick opened this issue Oct 13, 2021 · 3 comments
Open

New functionality: support tagging #35

maslick opened this issue Oct 13, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@maslick
Copy link

maslick commented Oct 13, 2021

Some organisations leverage Service Control Policies SCPs (e.g. for cost control) that enforce putting proper tags on your resources. In such scenarios CommandRunner won't be able to create an EC2 instance.

For this in addition to AWS::EC2::Instance we must use AWS::EC2::LaunchTemplate because Cloudformation puts tags on an EC2 instance in 2 API calls, whereas if you launch your EC2 based on a LaunchTemplate there will be 1 API call.

So we can add another parameter to the configuration file, fetch the tag list and programatically add tag parameters to BaseTemplate.json in CreateHandler.java .

@shantgup
Copy link
Collaborator

Thank you for the feedback @maslick, you are right this would cause an issue for organizations using SCP policies to enforce tagging. I will mark this as an FR as well.

Your activity on this repo is much appreciated, thank you. 🥇

@shantgup shantgup added the enhancement New feature or request label Feb 23, 2022
@pl-ajessop
Copy link

Hi, this would be a much appreciated feature - we use SCPs and can't use enforcement for this reason.

@shantgup
Copy link
Collaborator

Thank you @pl-ajessop, I will include this feature in the next minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants