Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS Pattern #8

Open
richardhboyd opened this issue Aug 1, 2020 · 2 comments
Open

KMS Pattern #8

richardhboyd opened this issue Aug 1, 2020 · 2 comments
Assignees

Comments

@richardhboyd
Copy link
Contributor

Can you add a pattern for a valid KMS Key Arn? Do you accept Aliases?

https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-codeartifact/blob/master/aws-codeartifact-domain/aws-codeartifact-domain.json#L20

@jonjara
Copy link
Contributor

jonjara commented Aug 28, 2020

we do accept alias:

The encryption key for the domain. This is used to encrypt content stored in a domain. An encryption key can be a key ID, a key Amazon Resource Name (ARN), a key alias, or a key alias ARN

According to api doc, the pattern is Pattern: \S+ , this is already a string type so I'll this like this for now.

@jonjara jonjara closed this as completed Aug 28, 2020
@richardhboyd
Copy link
Contributor Author

This fees like one of those times where, in the attempt to give developers the most flexibility, we have made it more confusing. By accepting many different types of values, we have precluded the possibility of automated tools to assist customers in defining this. cfn-lint will accept any string, even emojis?

@jonjara jonjara reopened this Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants