Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB inconsistent AttributeDefinitions / KeySchemas #1284

Merged
merged 8 commits into from Feb 15, 2020
Merged

DynamoDB inconsistent AttributeDefinitions / KeySchemas #1284

merged 8 commits into from Feb 15, 2020

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Jan 5, 2020

#1037

Generated documentation with:

pip3 install -e .
cfn-lint --update-documentation

$ cfn-lint test/fixtures/templates/bad/resources/dynamodb/un*

E3039 The set of Attributes in AttributeDefinitions: {'Album'} and KeySchemas: {'Album', 'Artist'} must match at Resources/dynamoDBTable/Properties
test/fixtures/templates/bad/resources/dynamodb/undefined_attribute_definition.yaml:6:5

E3039 The set of Attributes in AttributeDefinitions: {'Album', 'Artist', 'Sales'} and KeySchemas: {'Album', 'Artist'} must match at Resources/dynamoDBTable/Properties
test/fixtures/templates/bad/resources/dynamodb/unused_attribute_definition_1.yaml:6:5

E3039 The set of Attributes in AttributeDefinitions: {'Album', 'Artist', 'Sales'} and KeySchemas: {'Album', 'Artist'} must match at Resources/dynamoDBTable/Properties
test/fixtures/templates/bad/resources/dynamodb/unused_attribute_definition_2.yaml:6:5

Should probably ignore this rule for now if the AttributeName is anything other than a literal string

@PatMyron PatMyron requested a review from kddejong January 5, 2020 20:07
@codecov
Copy link

codecov bot commented Jan 5, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@2051ed0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1284   +/-   ##
=========================================
  Coverage          ?   87.73%           
=========================================
  Files             ?      138           
  Lines             ?     8142           
  Branches          ?     2000           
=========================================
  Hits              ?     7143           
  Misses            ?      592           
  Partials          ?      407

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2051ed0...6e1a075. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants