update E1019 and E1010 to handle attributes of a resource having type Map #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
PatMyron
reviewed
Aug 18, 2020
| # Check for maps | ||
| restypeparts = restype.split('.') | ||
| if restypeparts[0] in valid_getatts[resname] and len(restypeparts) >= 2: | ||
| if valid_getatts[resname][restypeparts[0]].get('Type') != 'Map': |
There was a problem hiding this comment.
@kddejong AWS::ServiceCatalog::CloudFormationProvisionedProduct's the only GetAtt Map so far:
curl -s --compressed https://d1uauaxba7bl26.cloudfront.net/latest/gzip/CloudFormationResourceSpecification.json | jq '.ResourceTypes' | jq 'with_entries(.value |= .Attributes)' | grep -v ': null' | grep -Eo 'Type": ".*"' | sort | uniq -c | sort -nr
504 Type": "String"
26 Type": "List"
6 Type": "Integer"
4 Type": "Boolean"
1 Type": "Map"
1 Type": "Json"
1 Type": "FindingsFilterListItem"so I was considering hardcoding that exception, but this seems even better 👍
There was a problem hiding this comment.
Yea, I'm not a huge fan of this solution. I think there are better long term solutions if this continues to grow.
kddejong
force-pushed
the
fix/1658
branch
2 times, most recently
from
56d4074
to
506c52b
Compare
kddejong
force-pushed
the
fix/1658
branch
5 times, most recently
from
562ddf1
to
ef509c2
Compare
This was referenced Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix #1658
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.