Add new rule E3018 to flag unwanted properties when a certain value exists #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddejong
force-pushed
the
new/rule/E3018
branch
from
a4c55c0
to
41c9d6e
Compare
|
For tracking after this PR is merged I will evaluate if these rules can be deleted and moved to this rule. This is a copy from #1746 (comment) but these rules more closely align with this new rule. https://github.com/aws-cloudformation/cfn-python-lint/blob/master/src/cfnlint/rules/resources/rds/AuroraScalingConfiguration.py |
kddejong
force-pushed
the
new/rule/E3018
branch
10 times, most recently
from
d9e231c
to
97659a4
Compare
kddejong
force-pushed
the
new/rule/E3018
branch
from
97659a4
to
00c3a00
Compare
This was referenced Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1746 (comment)
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.