Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::RDS::DBInstance drift detection false positive on NetworkType #1393

Closed
Tietew opened this issue Nov 10, 2022 · 3 comments
Closed

AWS::RDS::DBInstance drift detection false positive on NetworkType #1393

Tietew opened this issue Nov 10, 2022 · 3 comments

Comments

@Tietew
Copy link

Tietew commented Nov 10, 2022

Name of the resource

AWS::RDS::DBInstance

Resource Name

No response

Issue Description

On a DB instance with NetworkType: DUAL, drift detection reports NetworkType is REMOVED.

Expected Behavior

Expected in drift details shows following JSON:

{
  "AllocatedStorage": 20,
  "AvailabilityZone": "ap-northeast-1a",
  "BackupRetentionPeriod": 30,
  "CopyTagsToSnapshot": true,
  "DBInstanceClass": "db.t4g.small",
  "DBParameterGroupName": "xxx",
  "DBSubnetGroupName": "xxx",
  "DeletionProtection": true,
  "EnableCloudwatchLogsExports": [
    "error",
    "general"
  ],
  "EnablePerformanceInsights": true,
  "Engine": "mysql",
  "EngineVersion": "8.0.30",
  "NetworkType": "DUAL",
  "PerformanceInsightsRetentionPeriod": 7,
  "PreferredBackupWindow": "18:13-18:43",
  "PreferredMaintenanceWindow": "Sun:19:13-Sun:19:43",
  "PubliclyAccessible": false,
  "StorageEncrypted": true,
  "StorageType": "gp2",
  "VPCSecurityGroups": [
    "sg-xxx"
  ]
}

Observed Behavior

Actual in drift details shows following JSON (missing NetworkType):

{
  "AllocatedStorage": 20,
  "AvailabilityZone": "ap-northeast-1a",
  "BackupRetentionPeriod": 30,
  "CopyTagsToSnapshot": true,
  "DBInstanceClass": "db.t4g.small",
  "DBParameterGroupName": "xxx",
  "DBSubnetGroupName": "xxx",
  "DeletionProtection": true,
  "EnableCloudwatchLogsExports": [
    "error",
    "general"
  ],
  "EnablePerformanceInsights": true,
  "Engine": "mysql",
  "EngineVersion": "8.0.30",
  "PerformanceInsightsRetentionPeriod": 7,
  "PreferredBackupWindow": "18:13-18:43",
  "PreferredMaintenanceWindow": "sun:19:13-sun:19:43",
  "PubliclyAccessible": false,
  "StorageEncrypted": true,
  "StorageType": "gp2",
  "VPCSecurityGroups": [
    "sg-xxx"
  ]
}

Test Cases

Deploy a AWS::RDS::DBInstance with NetworkType: "DUAL", then detect drift.

Other Details

No response

@osdrv
Copy link

osdrv commented Feb 28, 2023

Our tests indicate the issue is completely fixed now. @Tietew any chance you could confirm this please?

@Tietew
Copy link
Author

Tietew commented Mar 2, 2023

@osdrv I have confirmed in ap-northeast-1. The drift status is now IN_SYNC. Thanks much!

@osdrv
Copy link

osdrv commented Mar 2, 2023

@Tietew great news, thank you!

@cfn-github-issues-bot cfn-github-issues-bot moved this from Coming Soon to Shipped in coverage-roadmap Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
coverage-roadmap
  
Shipped
Development

No branches or pull requests

3 participants