Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS::ECS::TaskDefinition - (new property) Secrets #30

Closed
TheDanBlanco opened this issue Jul 30, 2019 · 3 comments
Closed

AWS::ECS::TaskDefinition - (new property) Secrets #30

TheDanBlanco opened this issue Jul 30, 2019 · 3 comments
Labels
compute EC2, ECR, ECS, EKS, Lambda, Batch, Elastic Beanstalk, Serverless Application Repository
Projects
coverage-roadmap

Comments

@TheDanBlanco
Copy link

  1. Title -> AWS::EC2::TaskDefinition
  2. Scope of request -> AWS::EC2::TaskDefinition currently does not support secrets, but the ECS task definition api call does.
  3. Expected behavior -> Secrets should be consumed by TaskDefinition but not leaked.
  4. Test case recommendation (optional) ->
  5. Links to existing API doc (optional) -> https://docs.aws.amazon.com/cli/latest/reference/ecs/register-task-definition.html
  6. Category tag (optional) -> Compute
  7. Any additional context (optional) - > ecs containers roadmap issue: [ECS] [CloudFormation]: CloudFormation support for Secrets aws/containers-roadmap#97
@TheDanBlanco TheDanBlanco added the compute EC2, ECR, ECS, EKS, Lambda, Batch, Elastic Beanstalk, Serverless Application Repository label Jul 30, 2019
@TheDanBlanco TheDanBlanco added this to Shipped in coverage-roadmap Jul 30, 2019
@johnktims
Copy link

Should be AWS::ECS::TaskDefinition (not EC2).

@TheDanBlanco
Copy link
Author

Good catch!

@TheDanBlanco TheDanBlanco changed the title AWS::EC2::TaskDefinition - (new property) Secrets AWS::ECS::TaskDefinition - (new property) Secrets Jul 31, 2019
@fstendel
Copy link

Hi,

sorry if don't get the intent of this issues right.
But cloudformation is already supporting secets, isn't it?

Is this repository the right place to file feature requests/issues regarding current implementation as well?

Tnx

@PatMyron PatMyron mentioned this issue Aug 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compute EC2, ECR, ECS, EKS, Lambda, Batch, Elastic Beanstalk, Serverless Application Repository
Projects
coverage-roadmap
  
Shipped
Milestone
No milestone
Development

No branches or pull requests
4 participants
@johnktims @luiseduardocolon @fstendel @TheDanBlanco