Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Provide GitHub action #93

Open
thomasklinger1234 opened this issue Nov 5, 2020 · 2 comments
Open

[Enhancement] Provide GitHub action #93

thomasklinger1234 opened this issue Nov 5, 2020 · 2 comments
Labels
enhancement New feature or request needs-research

Comments

@thomasklinger1234
Copy link

Is your feature request related to a problem? Please describe.
We use GitHub actions a lot to ensure code style and compliance. A pre-built GitHub action would be awesome as it encapsulates running, configuration and installation of cfn-guard.

Describe the solution you'd like

The following configuration would be used in .github/workflows/cfn-guard.yml

---
name: pullrequest
on:
  pull_request:
    branches: [ main ]
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: aws-cloudformation/cloudformation-guard
        with:
          ruleset: "tools/cfn-guard/configuration/default.rules" # folder where rules reside
          templates: "cloudformation/*.template.yaml"

Open questions here:

  • how to check dynamic generated templates (e.g. by AWS CDK or other generators)?

Describe alternatives you've considered
Using the pre-commit check from #22 and then a dedicated action for it.

@thomasklinger1234 thomasklinger1234 added the enhancement New feature or request label Nov 5, 2020
@johnttompkins
Copy link
Contributor

This would be super powerful. We need to look into how exactly to vend these managed actions haven't done a whole lot of work with this side of GitHub actions.

@PatMyron
Copy link
Contributor

PatMyron commented Dec 3, 2020

#49 should be done first for inline comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-research
Projects
None yet
Development

No branches or pull requests

4 participants