Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example - Karpenter on Fargate #1159

Closed
micbegin opened this issue Nov 10, 2022 · 4 comments
Closed

Example - Karpenter on Fargate #1159

micbegin opened this issue Nov 10, 2022 · 4 comments
Assignees
Labels
blueprint enhancement New feature or request

Comments

@micbegin
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?

  • An example/blueprint that demonstrates how to create a cluster using a Fargate profile in which to run Karpenter.

Reference documentation:

Describe the solution you would like

  • An example that documents and provides the steps necessary to create an EKS cluster with a Fargate Profile where to run Karpenter using EKS blueprints
  • A default Karpenter provisioner using Bottlerocket AMI and a mix of spot and on-demand instances
  • A demo application to demonstrates how Karpenter scales nodes based on workload constraints like nodeSelector, topologySpreadConstraints, and podAntiAffinity
  • Other add-ons like aws-load-balancer-controller and external-dns running on fargate or nodes provisionned by Karpenter to demonstrate how a cluster can operate without any managed node groups

Describe alternatives you have considered

Additional context

I have tested this approach already and I have code that could be used to create this example.

@bryantbiggs
Copy link
Contributor

the current example for Karpenter is already configured for running on Fargate. If there are additional features/questions related to this pattern, please feel free to open a new issue describing the solution you would like to see or have answered

Ref: https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/examples/karpenter

@micbegin
Copy link
Contributor Author

I'm not sure why you are closing this issue since https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/examples/karpenter does not provide the following items:

  • A default Karpenter provisioner using Bottlerocket AMI and a mix of spot and on-demand instances
  • A demo application to demonstrates how Karpenter scales nodes based on workload constraints like nodeSelector, topologySpreadConstraints, and podAntiAffinity
  • Other add-ons like aws-load-balancer-controller and external-dns running on fargate or nodes provisionned by Karpenter to demonstrate how a cluster can operate without any managed node groups

Why are you asking me to open a new issue when this one already contains the proposed solution?

@bryantbiggs
Copy link
Contributor

bryantbiggs commented Jan 22, 2023

Because I don't think a separate example is warranted just for those items, no?

A default Karpenter provisioner using Bottlerocket AMI and a mix of spot and on-demand instances

What are we trying to demonstrate with this, what should users take away from the example? Is this just showing what you can do this with Karpenter, or is there something specific we are trying to highlight. Lastly - why are these important enough to highlight to users

A demo application to demonstrates how Karpenter scales nodes based on workload constraints like nodeSelector, topologySpreadConstraints, and podAntiAffinity

What makes this unique from a Karpenter perspective since these are Kubernetes constructs? What should users take away from demonstrating these?

Other add-ons like aws-load-balancer-controller and external-dns running on fargate or nodes provisionned by Karpenter to demonstrate how a cluster can operate without any managed node groups

I'm not following this one. We have an example that shows a fully serverless cluster running on Fargate profiles with a sample app and AWS LBC. If we want to add those addons here just to show resources running on compute provided by Karpenter, I think thats fine to add

@micbegin
Copy link
Contributor Author

I think it would have been better to clarify these points before working on the PR. The description of this issue is the same since Nov 10, 2022. I was assigned to it and no questions where asked at that time so I assumed it was OK.

I also tried to answer all the questions (similar to the ones you are asking here) that were asked in #1187 but did not get any feedback that could have help improving the PR.

@bryantbiggs bryantbiggs moved this from In review to Done in Old EKS Blueprints (Archived) Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blueprint enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants