fix: Add version property to http-event-schema #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
errorEventToJsErrorEvent
that creates aJsErrorEvent
to populate theerror
field in thehttp-event
.JsErrorEvent
by default addsversion
, which does not exist in the webclient's and dataplane'shttp-event
schema.FetchPlugin
andXhrPlugin
are unaware of the property details within theerror
object created byerrorEventToJsErrorEvent
.Fix:
http-event
schema to eliminate the schema difference between dataplane and web client and edits existing unit tests to check for theversion
property inFetchPlugin.test
andXhrPlugin.test
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.