Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add version property to http-event-schema #122

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

adebayor123
Copy link
Member

Problem:

  • When the web client creates an HTTP event that contains an error, it relies on errorEventToJsErrorEvent that creates a JsErrorEvent to populate the error field in the http-event. JsErrorEvent by default adds version, which does not exist in the webclient's and dataplane's http-event schema.
  • This was not caught on the web client as the FetchPlugin and XhrPlugin are unaware of the property details within the error object created by errorEventToJsErrorEvent.
  • As a result, any HTTP events that contains an error was rejected by the dataplane due to this event schema discrepancy.

Fix:

  • Dataplane event schema changes have been merged in.
  • This PR updates the http-event schema to eliminate the schema difference between dataplane and web client and edits existing unit tests to check for the version property in FetchPlugin.test and XhrPlugin.test.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@qhanam qhanam merged commit cf59ecb into aws-observability:main Mar 17, 2022
@adebayor123 adebayor123 deleted the http-event-schema branch March 21, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants