fix: 🐛 fix issue that decrement fetch counter was called always #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maniator
commented
May 5, 2022
qhanam
reviewed
May 5, 2022
maniator
force-pushed
the
fix-fetch-counter-bug
branch
2 times, most recently
from
e556d92
to
39cf7ea
Compare
Basically the finally call of fetch was not only being called on finally.
maniator
force-pushed
the
fix-fetch-counter-bug
branch
from
39cf7ea
to
bc96c0c
Compare
maniator
force-pushed
the
fix-fetch-counter-bug
branch
from
bc96c0c
to
88303dd
Compare
Happy to help :-) |
adebayor123
approved these changes
May 6, 2022
|
Good to merge? (I don't have the ability) |
adebayor123
pushed a commit
to adebayor123/aws-rum-web
that referenced
this pull request
May 11, 2022
…ty#145) * fix: 🐛 fix issue that decrement fetch counter was called always Basically the finally call of fetch was not only being called on finally. * test: 💍 add test for fetchCounter update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the finally call of fetch was not only being called on
finally.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.