fix: Only ignore PutRumEvents requests on proxy endpoints. #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web client currently ignores resource timings where the resource has the same host name as the RUM data plane endpoint. While this prevents an infinite loop of recording PutRumEvents requests, it is problematic when PutRumEvents requests are proxied through the same endpoint as the application server.
For example, I may have an endpoint which routes the following paths:
https://myapp.amazonaws.com/userhttps://myapp.amazonaws.com/gamma/application/aa17a42c-e737-48f7-adaf-2e0905f48073/eventsIn case (1), the request is related to the application logic, and the web client should record the request.
In case (2), the request is related to RUM, and the web client should not record the request.
This change solves the problem by checking the path fragment of the resource URL in addition to the host name of the resource URL. This allows the web client to disambiguate application requests from PutRumEvents proxy requests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.