Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add cause to Cognito and STS error messages #272

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

qhanam
Copy link
Member

@qhanam qhanam commented Oct 25, 2022

Cognito and STS error messages do not currently contain the underlying error.

This change adds the underlying error to the thrown error message.

This change also addresses three other issues in the authentication code:

  1. Fix an asynchrony issue where errors weren't being handled by the catch block.
  2. Refactor async functions to use async style instead of promise style.
  3. Fix linter warnings by adding explicit types to responses.

Resolves #227 and #233.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@qhanam qhanam merged commit 00563f5 into aws-observability:main Oct 25, 2022
@qhanam qhanam deleted the fix/cog-err-message branch October 25, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"CWR: Failed to retrieve Cognito identity" error thrown by aws-rum-web
3 participants