Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Populate method from Request Info #280

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

codermpl
Copy link
Contributor

@codermpl codermpl commented Nov 2, 2022

  • When in createHttpEvent, if there is no method on the RequestInit, then try to get the method from the RequestInfo

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- When in createHttpEvent, if there is no method on the RequestInit,
then try to get the method from the RequestInfo
Copy link
Member

@qhanam qhanam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; thank you!

@qhanam qhanam merged commit eb96760 into aws-observability:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants