Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create a session ID when cookies are disabled #314

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

ps863
Copy link
Member

@ps863 ps863 commented Nov 29, 2022

Presently, session ID is not created in all instances. Without a session ID, we are unable link events from the same page together.

This change will allow a session ID to be created in all instances. This allows all events tied to a single page to be linked together.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

src/sessions/__tests__/SessionManager.test.ts Outdated Show resolved Hide resolved
src/sessions/__tests__/SessionManager.test.ts Outdated Show resolved Hide resolved
ps863 and others added 2 commits November 30, 2022 11:14
Co-authored-by: Quinn Hanam <qhanam@gmail.com>
Co-authored-by: Quinn Hanam <qhanam@gmail.com>
@ps863 ps863 changed the title feat: Enable session creation in all instances to allow linking events from the same page feat: Create a session ID when cookies are disabled Dec 1, 2022
@ps863 ps863 merged commit 6943587 into aws-observability:main Dec 1, 2022
@ps863 ps863 deleted the singlePageSessions branch December 1, 2022 19:06
@ps863 ps863 mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants