Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Export PageAttributes type. #369

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

qhanam
Copy link
Member

@qhanam qhanam commented Mar 1, 2023

The recordPageView function accepts an argument of type PageAttributes, but this type is not exported.

This change exports the PageAttributes type.

Resolves #330


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@qhanam qhanam requested a review from limhjgrace March 1, 2023 01:35
@qhanam qhanam merged commit 4b78dc1 into aws-observability:main Mar 1, 2023
@qhanam qhanam deleted the export-page-attributes branch March 1, 2023 01:41
@williazz williazz mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PageAttributes is not exported from root.
2 participants