fix: Hardcode webclient version #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
question: does "resolveJsonModule": true remain true if we are hardcoding the web client version? |
has been removed |
ps863
approved these changes
Mar 7, 2023
|
Related to #381 |
qhanam
approved these changes
Mar 7, 2023
limhjgrace
added a commit
to limhjgrace/aws-rum-web
that referenced
this pull request
Mar 7, 2023
* fix: Hardcode webclient version * fix: Update test variable value * fix: update webclient version * fix: revert tsconfig changes related to webclient versioning feature * fix: remove version updating
limhjgrace
added a commit
to limhjgrace/aws-rum-web
that referenced
this pull request
Mar 7, 2023
* fix: Hardcode webclient version * fix: Update test variable value * fix: update webclient version * fix: revert tsconfig changes related to webclient versioning feature * fix: remove version updating
limhjgrace
added a commit
that referenced
this pull request
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications using cjs run into a
TypeErrordue to import issues involving theversion.jsonfile. Related issue: #371As a temporary fix, we will hardcode the webclient version.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.