fix: Record 0 for headerSize if transferSize is 0 #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qhanam
approved these changes
Jan 23, 2024
qhanam
pushed a commit
that referenced
this pull request
Jan 30, 2024
williazz
pushed a commit
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The navigation event schema validates that the
transferSizefield is non-negative. ThetransferSizefield is currently calculated by:headerSize - encodedBodySize. However,headerSizeis 0 if it the resource was instantaneously retrieved from a cache. This results in a negativeheaderSizeand thus, an invalid event that is dropped by CWR DP.This PR adds a check to ensure
transferSizeis greater than 0 when calculating theheaderSize.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.