Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Uncaught TypeError: Cannot read the properties of undefined (reading 'record') #75

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

madhuhc
Copy link
Contributor

@madhuhc madhuhc commented Dec 23, 2021

Adding a check when getSession() returns undefined to avoid JS error and breaking the page.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@qhanam qhanam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this!

Looks good to me, but please add the two unit tests I've proposed to verify the new behavior and prevent regressions.

src/plugins/event-plugins/FetchPlugin.ts Show resolved Hide resolved
src/plugins/event-plugins/XhrPlugin.ts Show resolved Hide resolved
@qhanam qhanam merged commit 0193480 into aws-observability:main Jan 11, 2022
adebayor123 added a commit to adebayor123/aws-rum-web that referenced this pull request Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants