Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: identify DOM events using CSS locator #87

Merged
merged 6 commits into from
Feb 15, 2022
Merged

feat: identify DOM events using CSS locator #87

merged 6 commits into from
Feb 15, 2022

Conversation

limhjgrace
Copy link
Contributor

Users currently configure the DOM event plugin to listen to events either with (1) the ID of the DOM element or (2) the actual JavaScript object. However, a customer may want to add a tag to certain elements which should be recorded. There is currently no way to listen for a certain tag.

This feature allows customers to specify listeners for DOM elements using CSS locators.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

src/plugins/event-plugins/DomEventPlugin.ts Outdated Show resolved Hide resolved
src/event-schemas/dom-event.json Outdated Show resolved Hide resolved
src/plugins/event-plugins/DomEventPlugin.ts Outdated Show resolved Hide resolved
src/plugins/event-plugins/DomEventPlugin.ts Outdated Show resolved Hide resolved
src/plugins/event-plugins/DomEventPlugin.ts Outdated Show resolved Hide resolved
src/plugins/event-plugins/DomEventPlugin.ts Outdated Show resolved Hide resolved
src/plugins/event-plugins/DomEventPlugin.ts Outdated Show resolved Hide resolved
src/plugins/event-plugins/DomEventPlugin.ts Outdated Show resolved Hide resolved
@limhjgrace limhjgrace changed the title feat: identify DOM events using CSS locators feat: identify DOM events using CSS locator Feb 15, 2022
@qhanam qhanam merged commit 1c911e0 into aws-observability:main Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants