Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ColdStart capture warning #208

Conversation

amirkaws
Copy link
Contributor

@amirkaws amirkaws commented Feb 14, 2023

Please provide the issue number

Issue number: 206

Summary

This PR addresses warning messages raised when coldstart up metrics is being captured.

Changes

Please provide a summary of what's being changed

Logic for empty metrics is changed not to show warning when user capture ColdStart metric

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from sliedig February 14, 2023 12:03
@github-actions github-actions bot added the bug Unexpected, reproducible and unintended software behaviour label Feb 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Base: 56.35% // Head: 56.35% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9188eef) compared to base (f854e95).
Patch coverage: 52.94% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #208   +/-   ##
========================================
  Coverage    56.35%   56.35%           
========================================
  Files           41       41           
  Lines         1778     1785    +7     
========================================
+ Hits          1002     1006    +4     
- Misses         776      779    +3     
Flag Coverage Δ
unittests 56.35% <52.94%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../AWS.Lambda.Powertools.Metrics/MetricsAttribute.cs 0.00% <0.00%> (ø)
...aries/src/AWS.Lambda.Powertools.Metrics/Metrics.cs 84.25% <50.00%> (+0.25%) ⬆️
...owertools.Metrics/Internal/MetricsAspectHandler.cs 76.00% <80.00%> (-0.60%) ⬇️
...da.Powertools.Logging/Internal/PowertoolsLogger.cs 90.41% <0.00%> (-0.55%) ⬇️
...ls.Metrics/Serializer/JsonNamingPolicyDecorator.cs 57.14% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amirkaws amirkaws changed the title fix: ColdStart capture warning and wrong metrics timestamp fix: ColdStart capture warning Feb 14, 2023
@sliedig sliedig merged commit 5e099f6 into aws-powertools:develop Feb 16, 2023
@amirkaws amirkaws deleted the amirkaws-cold-start-capture-warning-bug-fix branch February 24, 2023 14:55
@amirkaws amirkaws restored the amirkaws-cold-start-capture-warning-bug-fix branch February 24, 2023 14:55
@amirkaws amirkaws deleted the amirkaws-cold-start-capture-warning-bug-fix branch February 24, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected, reproducible and unintended software behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants