Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 - Params builders do not supply default TransformationManager #1544

Closed
scottgerring opened this issue Dec 29, 2023 · 1 comment
Closed
Labels
bug Something isn't working priority:2 High - core feature or affects 60% of the users status/staged-major-release This change will go with the next major release v2 Version 2

Comments

@scottgerring
Copy link
Contributor

Consider for instance SSMProvider - if a TransformationManager is not supplied, a default will not be provided. You can contrast this with CacheManager.

public SSMProvider build() {
if (cacheManager == null) {
cacheManager = new CacheManager();
}
SSMProvider provider;
if (client == null) {
client = createClient();
}
provider = new SSMProvider(cacheManager, transformationManager, client);
return provider;
}

This causes issues in our parameters example, which will throw due to a lack of TransformationManager:

MyObject jsonObj = ssmProvider.withTransformation(json).get("/powertools-java/sample/keyjson", MyObject.class);

Map<String, String> secretJson =
secretsProvider.withTransformation(json).get("/powertools-java/userpwd", Map.class);

What were you trying to accomplish?

Expected Behavior

V2 parameters example should work.

Possible Solution

A default TransformationManager should be provided.

@scottgerring scottgerring added bug Something isn't working v2 Version 2 priority:2 High - core feature or affects 60% of the users labels Dec 29, 2023
@scottgerring
Copy link
Contributor Author

@ritigupt working on this as part of #1546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:2 High - core feature or affects 60% of the users status/staged-major-release This change will go with the next major release v2 Version 2
Projects
None yet
Development

No branches or pull requests

1 participant