Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Verify release version is valid before proceeding #1362

Closed
1 of 2 tasks
heitorlessa opened this issue Jul 25, 2022 · 2 comments
Closed
1 of 2 tasks

Maintenance: Verify release version is valid before proceeding #1362

heitorlessa opened this issue Jul 25, 2022 · 2 comments
Labels
tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

heitorlessa commented Jul 25, 2022

Summary

As per discussion, we can be extra careful with the value of the release tag. While there isn't a scenario where this could be null, it could be a non-semantic value.

Why is this needed?

Prevent release workflow from failing or having unintended version published.

Which area does this relate to?

Automation

Solution

We could verify the value follows semantic versioning and is not null. Alternatively, we could also have a manual approval step for when the workflow runs.

Acknowledgment

@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes labels Jul 25, 2022
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Jul 25, 2022
@heitorlessa
Copy link
Contributor Author

We've moved towards a two-person release as all activities are automated now. This gives us enough safety and ensures our messaging is adequate to what we're releasing from more than one point of view.

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical Debt tasks
Projects
None yet
Development

No branches or pull requests

1 participant