Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(homepage): Replace poetry command to add group parameter #1917

Merged
merged 2 commits into from Feb 10, 2023
Merged

docs(homepage): Replace poetry command to add group parameter #1917

merged 2 commits into from Feb 10, 2023

Conversation

marcraminv
Copy link
Contributor

@marcraminv marcraminv commented Feb 9, 2023 •
edited by leandrodamascena

Issue number: #1920

Summary

Changes

Poetry changed and deprecated the --dev subcommand to define dev dependencies.

Now, they recommend using:

poetry add <deps_name> --group <group_name>

User experience

Before:

poetry add ... --dev

after

poetry add ... --group dev

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@marcraminv
Use new poetry subcommand to add dev deps
6092560 
Poetry changed and deprecated the `--dev` subcommand to define dev dependencies.

Now, they recommend using:

```
poetry add <deps_name> --group <group_name>
```

Signed-off-by: Marc Ramirez Invernon <marcraminv@gmail.com>
@marcraminv marcraminv requested a review from a team as a code owner February 9, 2023 16:36
@marcraminv marcraminv requested review from leandrodamascena and removed request for a team February 9, 2023 16:36
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Feb 9, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 9, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2023
@leandrodamascena leandrodamascena added do-not-merge need-issue PRs that are missing related issues labels Feb 9, 2023
@leandrodamascena
Copy link
Contributor

Hi @marcraminv! Thank you for submitting this PR. I added the "need-issue" and "do-not-merge" labels because according to our contribution guide, all PRs should have an issue to keep the tracker and governance in good shape.

Would you mind opening an issue? I can review this PR tomorrow.

Thank you.

@github-actions
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@leandrodamascena leandrodamascena changed the title Replace poetry subcommand to add dev deps docs(homepage): Replace poetry subcommand to add dev deps Feb 10, 2023
@leandrodamascena leandrodamascena removed do-not-merge need-issue PRs that are missing related issues labels Feb 10, 2023
@leandrodamascena
Copy link
Contributor

Hello @marcraminv! We are releasing a new version now and I opened the issue.

Thank you so much for this improvement. We strive to have good documentation because you know how important this is to our customers.

leandrodamascena
leandrodamascena approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leandrodamascena leandrodamascena changed the title docs(homepage): Replace poetry subcommand to add dev deps docs(homepage): Replace poetry command to add group parameter Feb 10, 2023
@leandrodamascena leandrodamascena merged commit d69953a into aws-powertools:develop Feb 10, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 10, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@marcraminv
Copy link
Contributor Author

Hey @leandrodamascena ! Thanks for merging, and sorry being late replying the thread. Next time I will open the ticket first 👍 😃

@leandrodamascena
Copy link
Contributor

Hey @leandrodamascena ! Thanks for merging, and sorry being late replying the thread. Next time I will open the ticket first +1 smiley

No problem @marcraminv! I'm glad you could contribute to this release! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrodamascena leandrodamascena leandrodamascena approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcraminv @leandrodamascena